GTest without filter separation #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I.e. otherwise we don't ever validate the proper execution of SetUp() and TearDown().
muggenhor
added a commit
that referenced
this pull request
Jun 2, 2017
I.e. running all cases in a single process, without respawning for every test case, is now possible without a failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HookRegistrationFixturedidn't do all it needed to do in its SetUp method. When running all test cases in a single source file at once this caused test failures.This PR both fixes that fixture (1a7b7b1) and runs the entire test suite at once, in addition to separated, to detect these kinds of failures in the future (04011a8).
This is the failure exposed by the different test execution (04011a8): https://travis-ci.org/muggenhor/cucumber-cpp/builds/219301662